linux-kernel - Re: [PATCHv2 6/7] block: add pi for nvme enhanced integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60060901-acd0-5b39-6d0f-13b0359b756d@acm.org>
Date:   Wed, 2 Feb 2022 10:40:59 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Keith Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Cc:     axboe@...nel.dk, hch@....de, martin.petersen@...cle.com,
        colyli@...e.de
Subject: Re: [PATCHv2 6/7] block: add pi for nvme enhanced integrity

On 2/1/22 11:01, Keith Busch wrote:
> +			ref = get_unaligned_be48(pi->ref_tag);
> +			seed = iter->seed & 0xffffffffffffull;

The "& 0xffffffffffffull" operation occurs three times in this patch. 
Has it been considered to introduce a lower_48_bits() function?

Thanks,

Bart.