linux-kernel - Re: [PATCH] dmaengine: ptdma: Fix the error handling path in pt_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d31d8348-c7ee-587a-d376-85e86092436f@wanadoo.fr>
Date:   Wed, 2 Feb 2022 19:45:57 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Sanjay R Mehta <sanju.mehta@....com>,
        Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ptdma: Fix the error handling path in
 pt_core_init()

Le 02/02/2022 à 08:15, Dan Carpenter a écrit :
> On Sun, Jan 30, 2022 at 03:12:09PM +0100, Christophe JAILLET wrote:
>> @@ -230,7 +230,7 @@ int pt_core_init(struct pt_device *pt)
>>   	/* Request an irq */
>>   	ret = request_irq(pt->pt_irq, pt_core_irq_handler, 0, dev_name(pt->dev), pt);
>>   	if (ret)
>> -		goto e_pool;
>> +		goto e_dma_alloc;
> 
> These are ComeFrom label names.  It's an unfortunate style of naming
> labels based on the goto location instead of saying what the goto does.
> 
> This is one of those cases where the code has moved on, and now the name
> no longer points to where it came from or to where it's going.  It just
> stands as a Hyperart Thomasson pointing to the past.  It reminds us of
> change and decay.  Take time to smell the air in autumn.  Beauty is all
> around.
> 
> regards,
> dan carpenter
> 

Autumn is over. Winter is coming (tm). And Spring will soon be there.

I'll try to send a refreshing update as a V2 to go one step further and 
do some spring cleaning in the labels used here.

CJ