linux-kernel - Re: [PATCH 5.16 0873/1039] PCI: pciehp: Use down_read/write_nested(reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 20:36:13 +0100
From:   Lukas Wunner <lukas@...ner.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Bjorn Helgaas <helgaas@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        Joseph Bao <joseph.bao@...el.com>
Subject: Re: [PATCH 5.16 0873/1039] PCI: pciehp: Use
 down_read/write_nested(reset_lock) to fix lockdep errors

On Tue, Jan 25, 2022 at 01:42:38PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 25, 2022 at 06:23:23AM -0600, Bjorn Helgaas wrote:
> > On Mon, Jan 24, 2022 at 07:44:22PM +0100, Greg Kroah-Hartman wrote:
> > > From: Hans de Goede <hdegoede@...hat.com>
> > > 
> > > commit 085a9f43433f30cbe8a1ade62d9d7827c3217f4d upstream.
> > 
> > I would hold off on backporting the pciehp changes until we resolve
> > this regression in v5.17-rc1:
> > 
> >   https://bugzilla.kernel.org/show_bug.cgi?id=215525
> 
> Thanks, I will drop it from all queues now.  If it gets resolved, please
> email stable@...r and we will be glad to add it back, along with the
> fix.

This turned out not to be an actual regression.  According to Bjorn,
"it was arguably a bug that it *did* work before", see:

https://lore.kernel.org/linux-pci/20220202164308.GA17822@bhelgaas/

Also, the culprit was not pciehp, but rather a change to _OSC handling
for VMD devices in commit 04b12ef163d1.

Thus, please consider re-adding these upstream commits to the stable queues:

  085a9f43433f30cbe8a1ade62d9d7827c3217f4d  (5.16, 5.15, 5.10)
  23584c1ed3e15a6f4bfab8dc5a88d94ab929ee12  (5.16, 5.15, 5.10, 5.4)

The release numbers in parentheses are the ones you originally queued the
commits up for.

Thanks!

Lukas