linux-kernel - [RFC PATCH] VMCI: dma dg: vmci_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Feb 2022 05:09:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jorgen Hansen <jhansen@...are.com>, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Cc:     kbuild-all@...ts.01.org, gregkh@...uxfoundation.org,
        pv-drivers@...are.com, Jorgen Hansen <jhansen@...are.com>,
        Vishnu Dasa <vdasa@...are.com>
Subject: [RFC PATCH] VMCI: dma dg: vmci_read_reg() can be static

drivers/misc/vmw_vmci/vmci_guest.c:93:14: warning: symbol 'vmci_read_reg' was not declared. Should it be static?
drivers/misc/vmw_vmci/vmci_guest.c:100:6: warning: symbol 'vmci_write_reg' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---
 vmci_guest.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
index d00430e5aba36..081f7b0c23f5f 100644
--- a/drivers/misc/vmw_vmci/vmci_guest.c
+++ b/drivers/misc/vmw_vmci/vmci_guest.c
@@ -90,14 +90,14 @@ u32 vmci_get_vm_context_id(void)
 	return vm_context_id;
 }
 
-unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
+static unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg)
 {
 	if (dev->mmio_base != NULL)
 		return readl(dev->mmio_base + reg);
 	return ioread32(dev->iobase + reg);
 }
 
-void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
+static void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg)
 {
 	if (dev->mmio_base != NULL)
 		writel(val, dev->mmio_base + reg);