[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=X_y3duGCN09sKOR0uZLft5x7OcLcBbbtT9EHi-4EGV6g@mail.gmail.com>
Date: Wed, 2 Feb 2022 13:26:24 -0800
From: Doug Anderson <dianders@...omium.org>
To: Sankeerth Billakanti <quic_sbillaka@...cinc.com>
Cc: dri-devel <dri-devel@...ts.freedesktop.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
freedreno <freedreno@...ts.freedesktop.org>,
LKML <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Rob Clark <robdclark@...il.com>,
Sean Paul <seanpaul@...omium.org>,
Stephen Boyd <swboyd@...omium.org>, quic_kalyant@...cinc.com,
quic_abhinavk@...cinc.com, quic_khsieh@...cinc.com,
quic_mkrishn@...cinc.com
Subject: Re: [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280
Hi,
On Mon, Jan 24, 2022 at 11:04 AM Doug Anderson <dianders@...omium.org> wrote:
>
> > +&mdss_edp {
> > + status = "okay";
> > +
> > + vdda-1p2-supply = <&vreg_l6b_1p2>;
> > + vdda-0p9-supply = <&vreg_l10c_0p8>;
> > +
> > + ports {
> > + port@1 {
> > + reg = <1>;
> > + edp_out: endpoint {
> > + remote-endpoint = <&edp_panel_in>;
> > + };
> > + };
> > + };
>
> I think part of the above should be in sc7280.dtsi. Basically in
> sc7820.dtsi I think you should have:
>
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> port@0 {
> reg = <0>;
> edp_in: endpoint {
> remote-endpoint = <&dpu_intf5_out>;
> };
> };
> port@1 {
> reg = <1>;
> edp_out: endpoint {
> };
> };
> };
>
> ...and then the crd dts file just needs:
>
> &edp_out {
> remote-endpoint = <&edp_panel_in>;
> };
>
> Right?
I've attempted to do the sc7280 part of this in:
https://lore.kernel.org/r/20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845fe20eec624c@changeid
Assuming folks think that's good then you should probably base your
next version atop that.
-Doug
Powered by blists - more mailing lists