lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Feb 2022 12:41:54 +0900 From: Sergey Senozhatsky <senozhatsky@...omium.org> To: Aditya Garg <gargaditya08@...e.com> Cc: "laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>, "laurent.pinchart+renesas@...asonboard.com" <laurent.pinchart+renesas@...asonboard.com>, "mchehab@...nel.org" <mchehab@...nel.org>, "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>, "hverkuil@...all.nl" <hverkuil@...all.nl>, "sergey.senozhatsky@...il.com" <sergey.senozhatsky@...il.com>, "ribalda@...omium.org" <ribalda@...omium.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, Orlando Chamberlain <redecorating@...tonmail.com>, "paul@...rm.io" <paul@...rm.io>, Aun-Ali Zaidi <admin@...eit.net>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera On (22/01/31 09:12), Aditya Garg wrote: > > On 26-Jan-2022, at 4:07 PM, Aditya Garg <gargaditya08@...e.com> wrote: > > > > From: Paul Pawlowski <paul@...rm.io> > > > > Adds the requisite device id to support detection of the Apple FaceTime > > HD webcam exposed over the T2 BCE VHCI interface. > > > > Tested-by: Aun-Ali Zaidi <admin@...eit.net> > > Signed-off-by: Paul Pawlowski <paul@...rm.io> > > Signed-off-by: Aun-Ali Zaidi <admin@...eit.net> > > Signed-off-by: Aditya Garg <gargaditya08@...e.com> I'm not the maintainer, but the patch looks OK to me FWIW Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org> Laurent, Ricardo, any thoughts? > > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > index 7c007426e..88dc9e7aa 100644 > > --- a/drivers/media/usb/uvc/uvc_driver.c > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = { > > .bInterfaceProtocol = 0, > > .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX > > | UVC_QUIRK_BUILTIN_ISIGHT) }, > > + /* Apple FaceTime HD Camera (Built-In) */ > > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > > + | USB_DEVICE_ID_MATCH_INT_INFO, > > + .idVendor = 0x05ac, > > + .idProduct = 0x8514, > > + .bInterfaceClass = USB_CLASS_VIDEO, > > + .bInterfaceSubClass = 1, > > + .bInterfaceProtocol = 0, > > + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def }, > > /* Apple Built-In iSight via iBridge */ > > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > > | USB_DEVICE_ID_MATCH_INT_INFO,
Powered by blists - more mailing lists