Message-ID: <20220202064950.qyomo7ns27mbedds@sx1>
Date:   Tue, 1 Feb 2022 22:49:50 -0800
From:   Saeed Mahameed <saeedm@...dia.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Mark Einon <mark.einon@...il.com>,
        Lino Sanfilippo <LinoSanfilippo@....de>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Shay Agroskin <shayagr@...zon.com>,
        Arthur Kiyanovski <akiyano@...zon.com>,
        David Arinzon <darinzon@...zon.com>,
        Noam Dagan <ndagan@...zon.com>,
        Saeed Bishara <saeedb@...zon.com>,
        Chris Snook <chris.snook@...il.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jeroen de Borst <jeroendb@...gle.com>,
        Catherine Sullivan <csully@...gle.com>,
        David Awogbemila <awogbemila@...gle.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "K . Y . Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Jon Mason <jdmason@...zu.us>,
        Simon Horman <simon.horman@...igine.com>,
        Rain River <rain.1986.08.12@...il.com>,
        Zhu Yanjun <zyjzyj2000@...il.com>,
        Shannon Nelson <snelson@...sando.io>,
        "drivers@...sando.io" <drivers@...sando.io>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Jiri Pirko <jiri@...nulli.us>,
        Edward Cree <ecree.xilinx@...il.com>,
        Martin Habets <habetsm.xilinx@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Michal Simek <michal.simek@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Vegard Nossum <vegard.nossum@...cle.com>,
        Rob Herring <robh@...nel.org>,
        "l.stelmach@...sung.com" <l.stelmach@...sung.com>,
        "rafal@...ecki.pl" <rafal@...ecki.pl>,
        Edwin Peer <edwin.peer@...adcom.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Chan <michael.chan@...adcom.com>,
        Richard Cochran <richardcochran@...il.com>,
        Gerhard Engleder <gerhard@...leder-embedded.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Gabriel Somlo <gsomlo@...il.com>,
        Joel Stanley <joel@....id.au>, Slark Xiao <slark_xiao@....com>,
        Liming Sun <limings@...dia.com>,
        David Thompson <davthompson@...dia.com>,
        Asmaa Mnebhi <asmaa@...dia.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Steen Hegelund <steen.hegelund@...rochip.com>,
        Prabhakar Kushwaha <pkushwaha@...vell.com>,
        Omkar Kulkarni <okulkarni@...vell.com>,
        Shai Malin <smalin@...vell.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Gary Guo <gary@...yguo.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-sunxi@...ts.linux.dev" <linux-sunxi@...ts.linux.dev>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "oss-drivers@...igine.com" <oss-drivers@...igine.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH net-next] net: kbuild: Don't default net vendor configs
 to y

On 02 Feb 06:30, Christophe Leroy wrote:
>
>
>Le 02/02/2022 à 06:16, Saeed Mahameed a écrit :
>> On 01 Feb 20:58, Jakub Kicinski wrote:
>>> On Tue, 1 Feb 2022 20:46:03 -0800 Saeed Mahameed wrote:
>>>> I am getting mixed messages here, on one hand we know that this patch
>>>> might break some old or def configs, but on the other hand people claim
>>>> that they have to manually fixup their own configs every time
>>>> "something in configs" changes and they are fine with that.
>>>>
>>>> Obviously I belong to the 2nd camp, hence this patch..
>>>>
>>>> I can sum it up with "it's fine to controllably break *some* .configs
>>>> for
>>>> the greater good" .. that's my .2cent.
>>>
>>> I think we agree that we don't care about oldconfigs IOW someone's
>>> random config.
>>>
>>> But we do care about defconfigs in the tree, if those indeed include
>>> ethernet drivers which would get masked out by vendor=n - they need
>>> fixin':
>>>
>>> $ find arch/ | grep defconfig
>>> arch/x86/configs/i386_defconfig
>>> arch/x86/configs/x86_64_defconfig
>>> arch/ia64/configs/generic_defconfig
>>> arch/ia64/configs/gensparse_defconfig
>>> ...
>>>
>>> First one from the top:
>>>
>>> $ make O=build_tmp/ i386_defconfig
>>> $ $EDITOR drivers/net/ethernet/intel/Kconfig
>>> $ git diff
>>> diff --git a/drivers/net/ethernet/intel/Kconfig
>>> b/drivers/net/ethernet/intel/Kconfig
>>> index 3facb55b7161..b9fdf2a835b0 100644
>>> --- a/drivers/net/ethernet/intel/Kconfig
>>> +++ b/drivers/net/ethernet/intel/Kconfig
>>> @@ -5,7 +5,6 @@
>>>
>>> config NET_VENDOR_INTEL
>>>        bool "Intel devices"
>>> -       default y
>>>        help
>>>          If you have a network (Ethernet) card belonging to this
>>> class, say Y.
>>>
>>> $ make O=build_tmp/ i386_defconfig
>>> $ diff -urpb build_tmp/.config.old build_tmp/.config
>>> --- build_tmp/.config.old    2022-02-01 20:55:37.087373905 -0800
>>> +++ build_tmp/.config    2022-02-01 20:56:32.126044628 -0800
>>> @@ -1784,22 +1784,7 @@ CONFIG_NET_VENDOR_GOOGLE=y
>>> # CONFIG_GVE is not set
>>> CONFIG_NET_VENDOR_HUAWEI=y
>>> # CONFIG_HINIC is not set
>>> -CONFIG_NET_VENDOR_I825XX=y
>>> -CONFIG_NET_VENDOR_INTEL=y
>>> -CONFIG_E100=y
>>> -CONFIG_E1000=y
>>> -CONFIG_E1000E=y
>>> -CONFIG_E1000E_HWTS=y
>>> -# CONFIG_IGB is not set
>>> -# CONFIG_IGBVF is not set
>>> -# CONFIG_IXGB is not set
>>> -# CONFIG_IXGBE is not set
>>> -# CONFIG_IXGBEVF is not set
>>> -# CONFIG_I40E is not set
>>> -# CONFIG_I40EVF is not set
>>> -# CONFIG_ICE is not set
>>> -# CONFIG_FM10K is not set
>>> -# CONFIG_IGC is not set
>>> +# CONFIG_NET_VENDOR_INTEL is not set
>>
>> We can introduce CONFIG_NET_LEGACY_VENDOR that selects all current vendors.
>> it will be off by default but will be added where needed in the defconfigs
>

Sorry I think i messed up my previous reply, here it's again just in case.

>Why such a hack ?
>

Reduced chance of error.

>I think we can fix all defconfig with some scripting, all you have to do
>it to add the relevant CONFIG_NET_VENDOR_SOMEONE=y wherever you find one
>of its boards in the defconfig.
>

Such a script could easily mess up!
I can't think of a clever easily verifiable way to map boards to their VENDORS.
Add to that dispersing the VENDORS configs accurately.

I might be just tired though, i will give it a shot in the morning :)

>Christophe

Powered by blists - more mailing lists