linux-kernel - Re: [PATCH v7 3/5] virt: Add efi_secret module to expose confidential computing secrets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 09:45:13 +0100
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Dov Murik <dovmurik@...ux.ibm.com>
Cc:     linux-efi@...r.kernel.org, Borislav Petkov <bp@...e.de>,
        Ashish Kalra <ashish.kalra@....com>,
        Brijesh Singh <brijesh.singh@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Andrew Scull <ascull@...gle.com>,
        Dave Hansen <dave.hansen@...el.com>,
        "Dr. David Alan Gilbert" <dgilbert@...hat.com>,
        Lenny Szubowicz <lszubowi@...hat.com>,
        Peter Gonda <pgonda@...gle.com>,
        James Bottomley <jejb@...ux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@...ux.ibm.com>,
        Jim Cadden <jcadden@....com>,
        Daniele Buono <dbuono@...ux.vnet.ibm.com>,
        linux-coco@...ts.linux.dev, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 3/5] virt: Add efi_secret module to expose
 confidential computing secrets

  Hi,

> +	s->coco_dir = NULL;
> +	s->fs_dir = NULL;
> +	memset(s->fs_files, 0, sizeof(s->fs_files));
> +
> +	dent = securityfs_create_dir("coco", NULL);
> +	if (IS_ERR(dent)) {
> +		pr_err("Error creating coco securityfs directory entry err=%ld\n", PTR_ERR(dent));
> +		return PTR_ERR(dent);
> +	}
> +	s->coco_dir = dent;
> +
> +	dent = securityfs_create_dir("efi_secret", s->coco_dir);
> +	if (IS_ERR(dent)) {
> +		pr_err("Error creating efi_secret securityfs directory entry err=%ld\n",
> +		       PTR_ERR(dent));
> +		return PTR_ERR(dent);
> +	}
> +	d_inode(dent)->i_op = &efi_secret_dir_inode_operations;
> +	s->fs_dir = dent;

Why have two levels of subdirectories here?  Do we expect more users for
the coco/ directory?

See also the naming discussion in the cover letter sub-thread.

take care,
  Gerd