[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2022 09:47:23 +0100
From: Gerd Hoffmann <kraxel@...hat.com>
To: Dov Murik <dovmurik@...ux.ibm.com>
Cc: linux-efi@...r.kernel.org, Borislav Petkov <bp@...e.de>,
Ashish Kalra <ashish.kalra@....com>,
Brijesh Singh <brijesh.singh@....com>,
Tom Lendacky <thomas.lendacky@....com>,
Ard Biesheuvel <ardb@...nel.org>,
James Morris <jmorris@...ei.org>,
"Serge E. Hallyn" <serge@...lyn.com>,
Andi Kleen <ak@...ux.intel.com>,
Greg KH <gregkh@...uxfoundation.org>,
Andrew Scull <ascull@...gle.com>,
Dave Hansen <dave.hansen@...el.com>,
"Dr. David Alan Gilbert" <dgilbert@...hat.com>,
Lenny Szubowicz <lszubowi@...hat.com>,
Peter Gonda <pgonda@...gle.com>,
James Bottomley <jejb@...ux.ibm.com>,
Tobin Feldman-Fitzthum <tobin@...ux.ibm.com>,
Jim Cadden <jcadden@....com>,
Daniele Buono <dbuono@...ux.vnet.ibm.com>,
linux-coco@...ts.linux.dev, linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 4/5] efi: Load efi_secret module if EFI secret area is
populated
On Tue, Feb 01, 2022 at 12:44:12PM +0000, Dov Murik wrote:
> If the efi_secret module is built, register a late_initcall in the EFI
> driver which checks whether the EFI secret area is available and
> populated, and then requests to load the efi_secret module.
> + area = memremap(efi.coco_secret, sizeof(*area), MEMREMAP_WB);
> + if (!area) {
> + pr_err("Failed to map confidential computing secret area descriptor\n");
> + return -ENOMEM;
> + }
> + if (!area->base_pa || area->size < sizeof(*header_guid))
> + goto unmap_desc;
> +
> + header_guid = (void __force *)ioremap_encrypted(area->base_pa, sizeof(*header_guid));
> + if (!header_guid) {
> + pr_err("Failed to map secret area\n");
> + ret = -ENOMEM;
> + goto unmap_desc;
> + }
> + if (efi_guidcmp(*header_guid, EFI_SECRET_TABLE_HEADER_GUID))
> + goto unmap_encrypted;
Why these sanity checks are here and not in the efi_secret module?
take care,
Gerd
Powered by blists - more mailing lists