[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2022 09:51:28 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
CC: Magnus Damm <magnus.damm@...il.com>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Prabhakar <prabhakar.csengg@...il.com>
Subject: RE: [PATCH v2] soc: renesas: Add support for reading product revision
for RZ/G2L family
Hi Geert,
> Subject: Re: [PATCH v2] soc: renesas: Add support for reading product
> revision for RZ/G2L family
>
> Hi Prabhakar,
>
> On Fri, Jan 21, 2022 at 2:41 AM Lad Prabhakar <prabhakar.mahadev-
> lad.rj@...renesas.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > As per RZ/G2L HW manual (Rev.1.00 Sep, 2021) DEV_ID [31:28] indicates
> > product revision. Use this information to populate the revision info
> > for RZ/G2L family.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > v1->v2
> > * Fixed freeing up soc_dev_attr in error path.
>
> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> i.e. will queue
> in renesas-devel for v5.18.
>
> > --- a/drivers/soc/renesas/renesas-soc.c
> > +++ b/drivers/soc/renesas/renesas-soc.c
> > @@ -405,41 +417,38 @@ static int __init renesas_soc_init(void)
> >
> > eshi = ((product >> 4) & 0x0f) + 1;
> > eslo = product & 0xf;
> > + soc_dev_attr->revision = kasprintf(GFP_KERNEL,
> "ES%u.%u",
> > + eshi, eslo);
> > + } else if (id == &id_rzg2l) {
> > + eshi = ((product >> 28) & 0x0f);
> > + soc_dev_attr->revision = kasprintf(GFP_KERNEL,
> "Rev %u",
> > + eshi);
>
> Would you mind if I would drop the "Rev " while applying?
Kernel reports the below message after dropping Rev. Is it OK?
[ 0.018297] Detected Renesas RZ/G2L r9a07g044 1
Cheers,
Biju
Powered by blists - more mailing lists