linux-kernel - Re: [PATCH 1/2] config: android-recommended: Don't explicitly disable CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 11:12:46 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     phone-devel@...r.kernel.org, Rob Herring <robh@...nel.org>,
        linux-kernel@...r.kernel.org, Amit Pundir <amit.pundir@...aro.org>,
        John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH 1/2] config: android-recommended: Don't explicitly
 disable CONFIG_AIO

On 2022-02-02 10:45:59, Greg Kroah-Hartman wrote:
> On Wed, Feb 02, 2022 at 10:33:13AM +0100, Marijn Suijten wrote:
> > Android nowadays (for a couple years already) requires AIO for at least
> > its `adb` "Android Debug Bridge" [1].  Without this config option
> > (`default y`) it simply refuses start, making users unable to connect to
> > their phone for debugging purposes when using these kernel fragments.
> > 
> > [1]: https://cs.android.com/android/_/android/platform/packages/modules/adb/+/a2cb8de5e68067a5e1d002886d5f3b42d91371e1
> > 
> > Cc: Amit Pundir <amit.pundir@...aro.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: John Stultz <john.stultz@...aro.org>
> > Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> > ---
> >  kernel/configs/android-recommended.config | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/kernel/configs/android-recommended.config b/kernel/configs/android-recommended.config
> > index eb0029c9a6a6..22bd76e43aca 100644
> > --- a/kernel/configs/android-recommended.config
> > +++ b/kernel/configs/android-recommended.config
> > @@ -1,5 +1,4 @@
> >  #  KEEP ALPHABETICALLY SORTED
> > -# CONFIG_AIO is not set
> >  # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
> >  # CONFIG_INPUT_MOUSE is not set
> >  # CONFIG_LEGACY_PTYS is not set
> > -- 
> > 2.35.1
> > 
> 
> There are lots of "required" configs now for modern Android releases, do
> you want to sync up with all of them here?  If so, look at the
> gki_defconfig files in the AOSP kernels for the full list of what is
> required.  Is it really needed to keep this file up to date or should it
> be dropped entirely given that no one has noticed how out-of-date it is?

This is all I need for now to get Android booting with a mainline
kernel, no fancy features though that make the device worthy of being a
phone (pending hardware drivers).  Perhaps replacing these config
fragments with gki_defconfig upstream is a good idea - as discussed with
John - but that's not something for me to decide nor embark on :).
Having them upstreamed might be nicer than finding the appropriate
corresponding downstream tree.

- Marijn