linux-kernel - Re: [PATCH] staging: greybus: fix an error handling bug in gb_svc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 11:27:40 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Mitchell Tasman <tasman@...flabs.com>,
        Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: fix an error handling bug in
 gb_svc_hello()

On Wed, Feb 02, 2022 at 10:20:16AM +0300, Dan Carpenter wrote:
> Cleanup if gb_svc_queue_deferred_request() fails.
> 
> Fixes: ee2f2074fdb2 ("greybus: svc: reconfig APBridgeA-Switch link to handle required load")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> From static analysis.  Not tested.

Look correct. Thanks, Dan.

This part of Greybus no longer lives in staging and the prefix should be

	greybus: svc:

I'd also prefer to see all error labels use an err_ prefix consistently.

When looking at this code I found another bug so I'll fix up the above
nits and send a series with both fixes as there will be a dependency.

>  drivers/greybus/svc.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c
> index ce7740ef449b..b19651048081 100644
> --- a/drivers/greybus/svc.c
> +++ b/drivers/greybus/svc.c
> @@ -866,8 +866,14 @@ static int gb_svc_hello(struct gb_operation *op)
>  
>  	gb_svc_debugfs_init(svc);
>  
> -	return gb_svc_queue_deferred_request(op);
> +	ret = gb_svc_queue_deferred_request(op);
> +	if (ret)
> +		goto remove_debugfs;
> +
> +	return 0;
>  
> +remove_debugfs:
> +	gb_svc_debugfs_exit(svc);
>  err_unregister_device:
>  	gb_svc_watchdog_destroy(svc);
>  	device_del(&svc->dev);

Johan