linux-kernel - Re: [PATCH v9] libperf: Add arm64 support to perf_mmap__read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 10:33:13 +0000
From:   John Garry <john.garry@...wei.com>
To:     Rob Herring <robh@...nel.org>, Will Deacon <will@...nel.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        "Arnaldo Carvalho de Melo" <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>
CC:     Masayoshi Mizuma <m.mizuma@...fujitsu.com>,
        <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9] libperf: Add arm64 support to perf_mmap__read_self()

On 01/02/2022 21:40, Rob Herring wrote:
> Add the arm64 variants for read_perf_counter() and read_timestamp().
> Unfortunately the counter number is encoded into the instruction, so the
> code is a bit verbose to enumerate all possible counters.
> 
> Tested-by: Masayoshi Mizuma <m.mizuma@...fujitsu.com>
> Signed-off-by: Rob Herring <robh@...nel.org>

Ha, I was just looking at this same topic yesterday from an old patchset 
[0] and wasn't aware of this separate change.

Tested-by: John Garry <john.garry@...wei.com>

[0] https://lore.kernel.org/all/20210311000837.3630499-1-robh@kernel.org/

BTW, Documentation/arm64/perf.rst has a reference to a file which does 
not seem to exit:

.. _tools/perf/arch/arm64/tests/user-events.c:
 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/arm64/tests/user-events.c

Thanks,
john