lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Feb 2022 12:03:32 +0100 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Rasmus Villemoes <linux@...musvillemoes.dk> Cc: Nick Desaulniers <ndesaulniers@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Nathan Chancellor <nathan@...nel.org>, Kees Cook <keescook@...omium.org>, linux-kernel <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev Subject: Re: [PATCH] include: drop pointless __compiler_offsetof indirection On Wed, Feb 2, 2022 at 11:21 AM Rasmus Villemoes <linux@...musvillemoes.dk> wrote: > > (1) compiler_types.h is unconditionally included via an -include > flag (see scripts/Makefile.lib), and it defines __compiler_offsetof > unconditionally. So testing for definedness of __compiler_offsetof is > mostly pointless. Sounds good to me. By the way, there are a bunch of `#include <linux/compiler_types.h>` around that could be removed. > (2) Every relevant compiler provides __builtin_offsetof (even sparse Indeed, even GCC 4. Reviewed-by: Miguel Ojeda <ojeda@...nel.org> Cheers, Miguel
Powered by blists - more mailing lists