linux-kernel - Re: [PATCH][next][V2] usb: gadget: f_uac2: change maxpctksize/maxpcktsize to wMaxPacketSize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 02 Feb 2022 03:09:11 -0800
From:   Joe Perches <joe@...ches.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pawel Laszczak <pawell@...ence.com>, linux-usb@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        pavel.hofman@...tera.com
Subject: Re: [PATCH][next][V2] usb: gadget: f_uac2: change
 maxpctksize/maxpcktsize to wMaxPacketSize

On Wed, 2022-02-02 at 10:40 +0000, Colin Ian King wrote:
> The spelling of maxpctksize and maxpcktsize is inconsistent, rename them
> both to wMaxPacketSize instead.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> V2: change both strings to wMaxPacketSize
[hmm]
> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
[]
> @@ -755,11 +755,11 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o
>  
>  	if (max_size_bw <= max_size_ep)
>  		dev_dbg(dev,
> -			"%s %s: Would use maxpctksize %d and bInterval %d\n",
> +			"%s %s: Would use wMaxPacketSize %d and bInterval %d\n",
>  			speed_names[speed], dir, max_size_bw, bint);
>  	else {
>  		dev_warn(dev,
> -			"%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n",
> +			"%s %s: Req. wMaxPacketSize %d at bInterval %d > max ISOC %d, may drop data!\n",
>  			speed_names[speed], dir, max_size_bw, bint, max_size_ep);

better still would be to align to the open parenthesis