lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Feb 2022 12:33:45 +0100 From: Johan Hovold <johan@...nel.org> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>, Mitchell Tasman <tasman@...flabs.com>, Dan Carpenter <dan.carpenter@...cle.com>, greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: [PATCH 1/3] greybus: svc: fix an error handling bug in gb_svc_hello() From: Dan Carpenter <dan.carpenter@...cle.com> Cleanup if gb_svc_queue_deferred_request() fails. Fixes: ee2f2074fdb2 ("greybus: svc: reconfig APBridgeA-Switch link to handle required load") Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Link: https://lore.kernel.org/r/20220202072016.GA6748@kili Cc: stable@...r.kernel.org # 4.9 [johan: fix commit summary prefix and rename label ] Signed-off-by: Johan Hovold <johan@...nel.org> --- drivers/greybus/svc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c index ce7740ef449b..51d0875a3480 100644 --- a/drivers/greybus/svc.c +++ b/drivers/greybus/svc.c @@ -866,8 +866,14 @@ static int gb_svc_hello(struct gb_operation *op) gb_svc_debugfs_init(svc); - return gb_svc_queue_deferred_request(op); + ret = gb_svc_queue_deferred_request(op); + if (ret) + goto err_remove_debugfs; + + return 0; +err_remove_debugfs: + gb_svc_debugfs_exit(svc); err_unregister_device: gb_svc_watchdog_destroy(svc); device_del(&svc->dev); -- 2.34.1
Powered by blists - more mailing lists