linux-kernel - Re: [PATCH] HID: i2c-hid: goodix: Fix a lockdep splat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 14:48:29 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Doug Anderson <dianders@...omium.org>
cc:     Daniel Thompson <daniel.thompson@...aro.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: i2c-hid: goodix: Fix a lockdep splat

On Fri, 28 Jan 2022, Doug Anderson wrote:

> > I'm was on the receiving end of a lockdep splat from this driver and after
> > scratching my head I couldn't be entirely sure it was a false positive
> > given we would also have to think about whether the regulator locking is
> > safe (since the notifier is called whilst holding regulator locks which
> > are also needed for regulator_is_enabled() ).
[ ... snip ... ]
> > Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> > ---
> >  drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 28 +++++++++++--------------
> >  1 file changed, 12 insertions(+), 16 deletions(-)
> 
> Yes, this seems like a reasonable solution, thanks! Probably want:
> 
> Fixes: 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line to true
> state of the regulator")
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

Thanks, queued for 5.17.

-- 
Jiri Kosina
SUSE Labs