[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2022 14:55:04 +0000
From: German Gomez <german.gomez@....com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...hat.com>,
Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf symbols: Remove demangle-rust files as superfluous
On 02/02/2022 00:12, Arnaldo Carvalho de Melo wrote:
> Em Tue, Feb 01, 2022 at 06:50:53PM +0000, German Gomez escreveu:
>> Demangling of Rust legacy symbols has been working through libbfd for
>> some time now, making these files no longer needed, so remove them.
> Can this be made dependent of the versions of the components that
> provide this feature?
Hi Arnaldo,
I have decided to drop this patch.
It turns out that even shipped versions of libbfd and libiberty don't demangle some of the symbols completely
For example:
(doesn't strip away the hash at the end) _ZN10rs_tracing8internal11TRACE_STATE17h41dcd282cd61069dE.0 ==> rs_tracing::internal::TRACE_STATE::h41dcd282cd61069d
(doesn't demangle full symbol) _ZN41_$LT$bool$u20$as$u20$core..fmt..Debug$GT$3fmt17h10f4b7b0094c3a75E.2262 ==> _$LT$bool$u20$as$u20$core..fmt..Debug$GT$::fmt::h10f4b7b0094c3a75
These are cleaned up afterwards by perf's demangler.
Apologies for not catching this earlier.
Thanks,
German
---
Tested with packages:
libbfd via binutils-dev(v2.34-6ubuntu1.3) on ubuntu 20.04
libiberty via libiberty-dev(v20200409-1) on ubuntu 20.04
>
> - Arnaldo
>
>> [...]
Powered by blists - more mailing lists