[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2022 18:13:39 +0300
From: Alexey Dobriyan <adobriyan@...il.com>
To: Kees Cook <keescook@...omium.org>
Cc: Eric Biederman <ebiederm@...ssion.com>,
Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
Ariadne Conill <ariadne@...eferenced.org>,
Michael Kerrisk <mtk.manpages@...il.com>,
Matthew Wilcox <willy@...radead.org>,
Christian Brauner <brauner@...nel.org>,
Rich Felker <dalias@...c.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH] selftests/exec: Avoid future NULL argv execve warning
On Mon, Jan 31, 2022 at 04:08:07PM -0800, Kees Cook wrote:
> Build actual argv for launching recursion test to avoid future warning
> about using an empty argv in execve().
> --- a/tools/testing/selftests/exec/recursion-depth.c
> +++ b/tools/testing/selftests/exec/recursion-depth.c
> @@ -24,8 +24,14 @@
> #include <sys/mount.h>
> #include <unistd.h>
>
> +#define FILENAME "/tmp/1"
> +#define HASHBANG "#!" FILENAME "\n"
> +
> int main(void)
> {
> + char * const argv[] = { FILENAME, NULL };
> + int rv;
Can we move out of -Wdeclaration-after-statement mentality in tests at least?
> - int rv = execve(FILENAME, NULL, NULL);
> + rv = execve(FILENAME, argv, NULL);
int rv = execve(FILENAME, (char*[]){FILENAME, NULL}, NULL);
is cleaner (and modern)!
> if (rv == -1 && errno == ELOOP) {
> return 0;
> }
Powered by blists - more mailing lists