[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8ab27937391733a9027a41af17a4a8155f78d549.camel@redhat.com>
Date: Thu, 03 Feb 2022 16:05:13 -0500
From: Lyude Paul <lyude@...hat.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, thierry.reding@...il.com,
sam@...nborg.org, airlied@...ux.ie, daniel@...ll.ch,
linus.walleij@...aro.org, dianders@...omium.org, ardb@...nel.org,
naresh.kamboju@...aro.org
Cc: rdunlap@...radead.org, arnd@...db.de,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>
Subject: Re: [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP
Reviewed-by: Lyude Paul <lyude@...hat.com>
On Thu, 2022-02-03 at 10:13 +0100, Thomas Zimmermann wrote:
> As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
> the option to fix the build failure. The issue has been reported
> before, when DisplayPort helpers where hidden behind the option
> CONFIG_DRM_KMS_HELPER. [2]
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper
> module")
> Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple")
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Lyude Paul <lyude@...hat.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: dri-devel@...ts.freedesktop.org
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 434c2861bb40..0aec5a10b064 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -106,6 +106,7 @@ config DRM_PANEL_EDP
> depends on PM
> select VIDEOMODE_HELPERS
> select DRM_DP_AUX_BUS
> + select DRM_DP_HELPER
> help
> DRM panel driver for dumb eDP panels that need at most a regulator
> and
> a GPIO to be powered up. Optionally a backlight can be attached so
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
Powered by blists - more mailing lists