[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20220203033033.52214-1-yang.lee@linux.alibaba.com>
Date: Thu, 3 Feb 2022 11:30:33 +0800
From: Yang Li <yang.lee@...ux.alibaba.com>
To: axboe@...nel.dk
Cc: philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, Yang Li <yang.lee@...ux.alibaba.com>,
Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH -next] mm/fs: fix boolreturn.cocci warning
Return statement in function returning bool should use true/false
instead of 1/0.
Eliminate the following coccicheck warning:
./drivers/block/drbd/drbd_req.c:912:9-10: WARNING: return of 0/1 in
function 'remote_due_to_read_balancing' with return type bool
Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
drivers/block/drbd/drbd_req.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index 2e5fb7e442e3..c8448379bbcd 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -909,7 +909,7 @@ static bool remote_due_to_read_balancing(struct drbd_device *device, sector_t se
switch (rbm) {
case RB_CONGESTED_REMOTE:
- return 0;
+ return false;
case RB_LEAST_PENDING:
return atomic_read(&device->local_cnt) >
atomic_read(&device->ap_pending_cnt) + atomic_read(&device->rs_pending_cnt);
--
2.20.1.7.g153144c
Powered by blists - more mailing lists