linux-kernel - Re: [PATCH -next] mm/fs: remove variable bdi set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220203080649.5q4c7rvowwgf4ssp@quack3.lan>
Date:   Thu, 3 Feb 2022 09:06:49 +0100
From:   Jan Kara <jack@...e.cz>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] mm/fs: remove variable bdi set but not used

On Thu 03-02-22 13:26:33, Yang Li wrote:
> The code that uses the pointer 'bdi' has been removed in commit:
> '37c32ade079f000c8e539730f254b14fae0d3b49' and inode_to_bdi() doesn't
> change 'inode', so the declaration and assignment of 'bdi' can be removed.
> 
> Eliminate the following clang warning:
> fs/ext2/ialloc.c:173:27: warning: variable 'bdi' set but not used
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Thanks! The patch looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext2/ialloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index d632764da240..998dd2ac8008 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
>  	unsigned long offset;
>  	unsigned long block;
>  	struct ext2_group_desc * gdp;
> -	struct backing_dev_info *bdi;
> -
> -	bdi = inode_to_bdi(inode);
>  
>  	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
>  	gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> -- 
> 2.20.1.7.g153144c
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR