Message-ID: <CAJKOXPfLSyrmr=dpqphnC-4dnEwaBP4-sOktW+TE8CY8r-=s6A@mail.gmail.com>
Date:   Thu, 3 Feb 2022 09:49:44 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sui Jingfeng <15330273260@....cn>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Roland Scheidegger <sroland@...are.com>,
        Zack Rusin <zackr@...are.com>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Andrey Zhizhikin <andrey.zhizhikin@...ca-geosystems.com>,
        Sam Ravnborg <sam@...nborg.org>,
        suijingfeng <suijingfeng@...ngson.cn>,
        linux-mips@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v6 3/3] dt-bindings: mips: loongson: introduce board
 specific dts

On Thu, 3 Feb 2022 at 09:26, Sui Jingfeng <15330273260@....cn> wrote:
>
> From: suijingfeng <suijingfeng@...ngson.cn>
>

You gave subject prefix "dt-bindings" but I do not see any bindings
here. Maybe you meant "MIPS: dts:" ?

> For board specific devices which is outside of the cpu and bridge chip.
> This patch introduce two dts, one for lemote a1901(aka LX-6901) motherboard
> which one only one vga output connected to DVO1.
> more document can be found from [1].
>
> Another one is ls3A4000+ls7a1000 evb board, this board have a VGA and DVO
> interface. The VGA is connected to the DVO0 and the dvi is connected to
> DVO1.
>
> We need introduce board specific dts because of we need the device tree
> to tell how does the connectors and encoders are connected to the DVO port
> of the display controller.

All this is unparseable. Could you use some more advanced grammar
check? If you can access Google GMail, it provides a really good
grammar helper.

>
> [1] https://wiki.godson.ac.cn/device:lemote_a1901
>
> Signed-off-by: suijingfeng <suijingfeng@...ngson.cn>
> Signed-off-by: Sui Jingfeng <15330273260@....cn>
> ---
>  arch/mips/boot/dts/loongson/lemote_a1901.dts  | 64 +++++++++++++++++
>  .../boot/dts/loongson/ls3a4000_7a1000_evb.dts | 68 +++++++++++++++++++
>  arch/mips/boot/dts/loongson/ls7a-pch.dtsi     |  2 +-
>  3 files changed, 133 insertions(+), 1 deletion(-)
>  create mode 100644 arch/mips/boot/dts/loongson/lemote_a1901.dts
>  create mode 100644 arch/mips/boot/dts/loongson/ls3a4000_7a1000_evb.dts
>
> diff --git a/arch/mips/boot/dts/loongson/lemote_a1901.dts b/arch/mips/boot/dts/loongson/lemote_a1901.dts
> new file mode 100644
> index 000000000000..81828945ba52
> --- /dev/null
> +++ b/arch/mips/boot/dts/loongson/lemote_a1901.dts
> @@ -0,0 +1,64 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +/dts-v1/;
> +
> +#include "loongson64g-package.dtsi"
> +#include "ls7a-pch.dtsi"
> +
> +/ {
> +       compatible = "lemode,a1901", "loongson,loongson64g-4core-ls7a";

You need to document the new compatible in the bindings.

> +       model = "lemode,a1901";

Model should not be the same as compatible but a user-parseable string.

> +};
> +
> +&package0 {
> +       htvec: interrupt-controller@...fb000080 {
> +               compatible = "loongson,htvec-1.0";
> +               reg = <0xefd 0xfb000080 0x40>;
> +               interrupt-controller;
> +               #interrupt-cells = <1>;
> +
> +               interrupt-parent = <&liointc>;
> +               interrupts = <24 IRQ_TYPE_LEVEL_HIGH>,
> +                            <25 IRQ_TYPE_LEVEL_HIGH>,
> +                            <26 IRQ_TYPE_LEVEL_HIGH>,
> +                            <27 IRQ_TYPE_LEVEL_HIGH>,
> +                            <28 IRQ_TYPE_LEVEL_HIGH>,
> +                            <29 IRQ_TYPE_LEVEL_HIGH>,
> +                            <30 IRQ_TYPE_LEVEL_HIGH>,
> +                            <31 IRQ_TYPE_LEVEL_HIGH>;
> +       };
> +};
> +
> +&pch {
> +       msi: msi-controller@...00000 {
> +               compatible = "loongson,pch-msi-1.0";
> +               reg = <0 0x2ff00000 0 0x8>;
> +               interrupt-controller;
> +               msi-controller;
> +               loongson,msi-base-vec = <64>;
> +               loongson,msi-num-vecs = <192>;
> +               interrupt-parent = <&htvec>;
> +       };
> +};
> +
> +&lsdc {
> +       /* use_vram_helper; */
> +       output-ports = <&dvo0 &dvo1>;
> +
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +
> +       dvo0: dvo@0 {
> +               /* 0 for DVO0 */
> +               reg = <0>;
> +               status = "disabled";
> +       };
> +
> +       dvo1: dvo@1 {
> +               /* 1 for DVO1 */
> +               reg = <1>;
> +               connector = "vga-connector";
> +               encoder = "adi,adv7125";
> +               status = "okay";
> +       };
> +};
> diff --git a/arch/mips/boot/dts/loongson/ls3a4000_7a1000_evb.dts b/arch/mips/boot/dts/loongson/ls3a4000_7a1000_evb.dts
> new file mode 100644
> index 000000000000..ff07f529ea43
> --- /dev/null
> +++ b/arch/mips/boot/dts/loongson/ls3a4000_7a1000_evb.dts
> @@ -0,0 +1,68 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +/dts-v1/;
> +
> +#include "loongson64g-package.dtsi"
> +#include "ls7a-pch.dtsi"
> +
> +/ {
> +       compatible = "loongson,loongson64g-4core-ls7a";
> +       model = "loongson,ls3a4000_7a1000_evb";
> +       version = "v1.4";

Is there such a dt property?


Best regards,
Krzysztof

Powered by blists - more mailing lists