linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: sc7280: Add lpass cpu node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdd74ba3-935d-b5fa-e642-6fedaf33116c@quicinc.com>
Date:   Thu, 3 Feb 2022 16:37:09 +0530
From:   Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <devicetree@...r.kernel.org>,
        <dianders@...omium.org>, <judyhsiao@...omium.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <robh+dt@...nel.org>, <rohitkr@...eaurora.org>,
        <srinivas.kandagatla@...aro.org>
CC:     Venkata Prasad Potturu <quic_potturu@...cinc.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sc7280: Add lpass cpu node


On 1/6/2022 2:37 AM, Stephen Boyd wrote:
Thanks for Your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-01-03 03:12:59)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index c0d9de3..68c7755 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -17,6 +17,7 @@
>>   #include <dt-bindings/reset/qcom,sdm845-aoss.h>
>>   #include <dt-bindings/reset/qcom,sdm845-pdc.h>
>>   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> +#include <dt-bindings/sound/qcom,lpass.h>
>>   #include <dt-bindings/thermal/thermal.h>
>>
>>   / {
>> @@ -1840,6 +1841,62 @@
>>                          #size-cells = <0>;
>>                  };
>>
>> +               lpass_cpu: qcom,lpass@...0000 {
> audio-subsystem@...0000?
Okay. will change accordingly.
>
>> +                       compatible = "qcom,sc7280-lpass-cpu";
>> +                       reg = <0 0x3260000 0 0xC000>,
>> +                               <0 0x3280000 0 0x29000>,
>> +                               <0 0x3340000 0 0x29000>,
>> +                               <0 0x336C000 0 0x3000>,
>> +                               <0 0x3987000 0 0x68000>,
>> +                               <0 0x3B00000 0 0x29000>;
>> +                       reg-names = "lpass-rxtx-cdc-dma-lpm",
>> +                                       "lpass-rxtx-lpaif",
>> +                                       "lpass-va-lpaif",
>> +                                       "lpass-va-cdc-dma-lpm",
>> +                                       "lpass-hdmiif",
>> +                                       "lpass-lpaif";
>> +
>> +                       iommus = <&apps_smmu 0x1820 0>,
>> +                               <&apps_smmu 0x1821 0>,
>> +                               <&apps_smmu 0x1832 0>;
>> +                       status = "disabled";
>> +
>> +                       power-domains = <&rpmhpd SC7280_LCX>;
>> +                       power-domain-names = "lcx";
>> +                       required-opps = <&rpmhpd_opp_nom>;
>> +
>> +                       clocks = <&lpass_aon LPASS_AON_CC_AUDIO_HM_H_CLK>,
>> +                                       <&lpasscc LPASS_CORE_CC_SYSNOC_MPORT_CORE_CLK>,
>> +                                       <&lpass_audiocc LPASS_AUDIO_CC_CODEC_MEM0_CLK>,
>> +                                       <&lpass_audiocc LPASS_AUDIO_CC_CODEC_MEM1_CLK>,
>> +                                       <&lpass_audiocc LPASS_AUDIO_CC_CODEC_MEM2_CLK>,
>> +                                       <&lpasscc LPASS_CORE_CC_EXT_IF0_IBIT_CLK>,
>> +                                       <&lpasscc LPASS_CORE_CC_EXT_IF1_IBIT_CLK>,
>> +                                       <&lpass_aon LPASS_AON_CC_VA_MEM0_CLK>;
>> +                       clock-names = "aon_cc_audio_hm_h",
>> +                                       "core_cc_sysnoc_mport_core",
>> +                                       "audio_cc_codec_mem0",
>> +                                       "audio_cc_codec_mem1",
>> +                                       "audio_cc_codec_mem2",
>> +                                       "core_cc_ext_if0_ibit",
>> +                                       "core_cc_ext_if1_ibit",
>> +                                       "aon_cc_va_mem0";
> Please align these things on " and <.
Okay.
>
>> +
>> +                       #sound-dai-cells = <1>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +
>> +                       interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
>> +                                               <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>,
>> +                                               <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>,
>> +                                               <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> +                       interrupt-names = "lpass-irq-lpaif",
>> +                                       "lpass-irq-vaif",
>> +                                       "lpass-irq-rxtxif",
>> +                                       "lpass-irq-hdmi";
> Same.
Okay.
>
>> +               };
>> +
>>                  vamacro: codec@...0000 {
>>                          compatible = "qcom,sc7280-lpass-va-macro";
>>                          pinctrl-0 = <&dmic01_active>;
>> --
>> 2.7.4
>>