linux-kernel - Re: [Patch v4] PCI: hv: Fix NUMA node assignment when kernel boots with custom NUMA topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220203124627.qudi3mmmyv4aee5w@liuwe-devbox-debian-v2>
Date:   Thu, 3 Feb 2022 12:46:27 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     longli@...uxonhyperv.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org,
        paekkaladevi@...rosoft.com, Long Li <longli@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>
Subject: Re: [Patch v4] PCI: hv: Fix NUMA node assignment when kernel boots
 with custom NUMA topology

On Thu, Feb 03, 2022 at 12:42:46PM +0000, Lorenzo Pieralisi wrote:
> On Wed, Jan 26, 2022 at 05:43:34PM -0800, longli@...uxonhyperv.com wrote:
> > From: Long Li <longli@...rosoft.com>
> > 
> > When kernel boots with a NUMA topology with some NUMA nodes offline, the PCI
> > driver should only set an online NUMA node on the device. This can happen
> > during KDUMP where some NUMA nodes are not made online by the KDUMP kernel.
> > 
> > This patch also fixes the case where kernel is booting with "numa=off".
> > 
> > Fixes: 999dd956d838 ("PCI: hv: Add support for protocol 1.3 and support PCI_BUS_RELATIONS2")
> > Signed-off-by: Long Li <longli@...rosoft.com>
> > Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> > ---
> > Change log:
> > v2: use numa_map_to_online_node() to assign a node to device (suggested by
> > Michael Kelly <mikelley@...rosoft.com>)
> > v3: add "Fixes" and check for num_possible_nodes()
> > v4: fix commit message format
> > 
> >  drivers/pci/controller/pci-hyperv.c | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> Feel free to pick it up:
> 
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

Thanks Lorenzo.