linux-kernel - Re: [PATCH 2/3] ARM: dts: exynos: add simple battery to p4note

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <787b0060-266e-0efd-1bbb-43c33abcbb24@canonical.com>
Date:   Thu, 3 Feb 2022 16:36:24 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Martin Jücker <martin.juecker@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Russell King <linux@...linux.org.uk>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: exynos: add simple battery to p4note

On 02/02/2022 17:34, Martin Jücker wrote:
> Add a simple battery node to the p4note device tree to set the missing
> values for the charger to work properly.
> 
> Signed-off-by: Martin Jücker <martin.juecker@...il.com>
> ---
>  arch/arm/boot/dts/exynos4412-p4note.dtsi | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> index 63459db653ea..fcd75cceb877 100644
> --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> @@ -115,6 +115,17 @@ wlan_pwrseq: sdhci3-pwrseq {
>  		clock-names = "ext_clock";
>  	};
>  
> +	battery_cell: battery-cell {
> +		compatible = "simple-battery";
> +		device-chemistry = "lithium-ion";
> +		constant-charge-current-max-microamp = <2200000>;
> +		precharge-current-microamp = <250000>;
> +		charge-term-current-microamp = <250000>;
> +		constant-charge-voltage-max-microvolt = <4200000>;
> +
> +		power-supplies = <&power_supply>;
> +	};
> +
>  	i2c-gpio-1 {
>  		compatible = "i2c-gpio";
>  		sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -193,7 +204,7 @@ i2c-gpio-4 {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		charger@6 {
> +		power_supply: charger@6 {

Squash this change with the previous patch. No need to add a line and
immediately change it in next patch.

>  			compatible = "summit,smb347";
>  			reg = <0x6>;
>  			summit,enable-usb-charging;
> @@ -201,6 +212,8 @@ charger@6 {
>  			summit,fast-voltage-threshold-microvolt = <2600000>;
>  			summit,chip-temperature-threshold-celsius = <130>;
>  			summit,usb-current-limit-microamp = <1800000>;
> +
> +			monitored-battery = <&battery_cell>;
>  		};
>  	};
>  


Best regards,
Krzysztof