linux-kernel - Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <123d2444-9f61-7d9c-66d4-7e981dbc945f@ti.com>
Date:   Thu, 3 Feb 2022 09:56:15 -0600
From:   Suman Anna <s-anna@...com>
To:     Tony Lindgren <tony@...mide.com>,
        Drew Fustini <dfustini@...libre.com>
CC:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Keerthy <j-keerthy@...com>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Tero Kristo <kristo@...nel.org>, <khilman@...libre.com>
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from
 errata i940 fix

Hi Drew,

On 2/3/22 00:53, Tony Lindgren wrote:
> * Drew Fustini <dfustini@...libre.com> [220202 23:26]:
>> I modified the errata fix to use timer 15 and 16 instead which resolves
>> the timer conflict.
> 
> Makes sens to me, just one nit below.
> 
>> Note: I am keeping the device tree and driver change together in one
>> patch as that is how the original errata fix commit was structured.
> 
> Yes.. The old dtb handling for the timer driver causes this dependency
> unfortunately.

Can you also add the cyclictest info to the commit log when you repost v2?

regards
Suman

> 
>> --- a/drivers/clocksource/timer-ti-dm-systimer.c
>> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
>> @@ -695,9 +695,9 @@ static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa)
>>  		return 0;
>>  	}
>>  
>> -	if (pa == 0x48034000)		/* dra7 dmtimer3 */
>> +	if (pa == 0x4882C000)           /* dra7 dmtimer15 */
>>  		return dmtimer_percpu_timer_init(np, 0);
>> -	else if (pa == 0x48036000)	/* dra7 dmtimer4 */
>> +	else if (pa == 0x4882E000)      /* dra7 dmtimer16 */
>>  		return dmtimer_percpu_timer_init(np, 1);
>>  
>>  	return 0;
> 
> Linux use lower case hex number typically :)
> 
> With that, please feel free to add:
> 
> Reviewed-by: Tony Lindgren <tony@...mide.com>