linux-kernel - Re: [PATCH -next] drm/amdkfd: Fix resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b97d5d0c-e54d-332b-73f6-3c5b0e6cf7a6@amd.com>
Date:   Thu, 3 Feb 2022 12:19:23 -0500
From:   Felix Kuehling <felix.kuehling@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, daniel@...ll.ch
Cc:     airlied@...ux.ie, Xinhui.Pan@....com, christian.koenig@....com,
        alexander.deucher@....com, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] drm/amdkfd: Fix resource_size.cocci warning


Am 2022-02-03 um 00:04 schrieb Yang Li:
> Use resource_size function on resource object instead of explicit
> computation.
>
> Eliminate the following coccicheck warning:
> ./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:978:11-14: ERROR: Missing
> resource_size with res
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>


This patch was already applied in September: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0de5472a01804f43b7c8ddb1132bbfeb8b68674f

Which branch is this for?

Regards,
   Felix



> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index 8430f6475723..d4287a39be56 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -975,7 +975,7 @@ int svm_migrate_init(struct amdgpu_device *adev)
>   		pgmap->type = 0;
>   		if (pgmap->type == MEMORY_DEVICE_PRIVATE)
>   			devm_release_mem_region(adev->dev, res->start,
> -						res->end - res->start + 1);
> +						resource_size(res));
>   		return PTR_ERR(r);
>   	}
>