linux-kernel - Re: [PATCH v1] printk: Fix incorrect __user type in proc_dointvec_minmax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yf2f5lh9JEremKKr@bombadil.infradead.org>
Date:   Fri, 4 Feb 2022 13:51:34 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Mickaël Salaün <mic@...ikod.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        John Ogness <john.ogness@...utronix.de>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Xiaoming Ni <nixiaoming@...wei.com>,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Mickaël Salaün <mic@...ux.microsoft.com>
Subject: Re: [PATCH v1] printk: Fix incorrect __user type in
 proc_dointvec_minmax_sysadmin()

On Fri, Feb 04, 2022 at 12:09:55PM +0900, Sergey Senozhatsky wrote:
> On (22/02/03 15:50), Mickaël Salaün wrote:
> > The move of proc_dointvec_minmax_sysadmin() from kernel/sysctl.c to
> > kernel/printk/sysctl.c introduced an incorrect __user attribute to the
> > buffer argument.  I spotted this change in [1] as well as the kernel
> > test robot.  Revert this change to please sparse:
> > 
> > kernel/printk/sysctl.c:20:51: warning: incorrect type in argument 3 (different address spaces)
> > kernel/printk/sysctl.c:20:51:    expected void *
> > kernel/printk/sysctl.c:20:51:    got void [noderef] __user *buffer
> > 
> > Fixes: faaa357a55e0 ("printk: move printk sysctl to printk/sysctl.c")
> > Link: https://lore.kernel.org/r/20220104155024.48023-2-mic@digikod.net [1]
> > Reported-by: kernel test robot <lkp@...el.com>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: John Ogness <john.ogness@...utronix.de>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: Luis Chamberlain <mcgrof@...nel.org>
> > Cc: Petr Mladek <pmladek@...e.com>
> > Cc: Sergey Senozhatsky <senozhatsky@...omium.org>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Xiaoming Ni <nixiaoming@...wei.com>
> > Signed-off-by: Mickaël Salaün <mic@...ux.microsoft.com>
> > Link: https://lore.kernel.org/r/20220203145029.272640-1-mic@digikod.net
> 
> Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>