[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=VDA_=pW0jHPi=OpLf6xhe_Ln_eUPrCAoTzK_qyvb9XSQ@mail.gmail.com>
Date: Fri, 4 Feb 2022 14:14:58 -0800
From: Doug Anderson <dianders@...omium.org>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: Prasad Malisetty <pmaliset@...eaurora.org>,
Matthias Kaehlcke <mka@...omium.org>, quic_rjendra@...cinc.com,
Shaik Sajida Bhanu <sbhanu@...eaurora.org>,
kgodara@...eaurora.org,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Sankeerth Billakanti <quic_sbillaka@...cinc.com>,
Sibi Sankar <sibis@...eaurora.org>,
Stephen Boyd <swboyd@...omium.org>,
Andy Gross <agross@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 12/14] arm64: dts: qcom: sc7280: Add herobrine-r1
Hi,
On Thu, Feb 3, 2022 at 3:26 PM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Wed, Feb 2, 2022 at 1:24 PM Douglas Anderson <dianders@...omium.org> wrote:
> >
> > +&pcie1_clkreq_n {
> > + bias-disable;
> > + drive-strength = <2>;
> > +};
>
> As per the discussion [1] then maybe the above should be
> `bias-pull-up` instead of `bias-disable`. I'm happy to spin this, have
> it fixed by the maintainer when applied, or do a follow-up patch to
> fix this. Please let me know.
Breadcrumbs: since most of this series landed but not this patch, I've
sent a new version with the fixup.
https://lore.kernel.org/r/20220204140550.v4.1.I5604b7af908e8bbe709ac037a6a8a6ba8a2bfa94@changeid/
Powered by blists - more mailing lists