linux-kernel - Re: [PATCH] tools/lib/thermal: Add a thermal library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c610f361-14b5-6c64-ff28-7ae0442aed71@linaro.org>
Date:   Fri, 4 Feb 2022 23:16:21 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Viktor Rosendahl <Viktor.Rosendahl@....de>,
        Sasha Levin <sashal@...nel.org>,
        Colin Ian King <colin.king@...el.com>,
        "Zhang, Rui" <rui.zhang@...el.com>
Subject: Re: [PATCH] tools/lib/thermal: Add a thermal library


Hi Srinivas,

On 04/02/2022 20:32, srinivas pandruvada wrote:
> On Fri, 2022-02-04 at 18:11 +0100, Rafael J. Wysocki wrote:
>> CC Rui and Srinivas
>>
>> On Fri, Feb 4, 2022 at 5:15 PM Daniel Lezcano
>> <daniel.lezcano@...aro.org> wrote:
>>>
>>> The thermal framework implements a netlink notification mechanism
>>> to
>>> be used by the userspace to have a thermal configuration discovery,
>>> trip point changes or violation, cooling device changes
>>> notifications,
>>> etc...
>>>
>>> This library provides a level of abstraction for the thermal
>>> netlink
>>> notification allowing the userspace to connect to the notification
>>> mechanism more easily. The library is callback oriented.
>>>
>>> As it is the very first iteration, the API may be subject to
>>> changes. For this reason, the documentation will be provided after
>>> those are stabilized.
>>
>> So shouldn't this be an RFC?
>>
>> Also, I would prefer documentation to be provided or at least some
>> intended usage examples to be given.
>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>>> ---
>>>   tools/Makefile                           |  14 +-
>>>   tools/include/uapi/linux/thermal.h       |  91 ++++++
> This is duplicating the file at include/uapi/linux. I know this is done
> for other tools also. In my use I am copying and using symbolic link.

Why copy and symbolic link ? Should it be create a symbolic link only ?

> BTW I have potential usage of netlink targeted for next release in
> linux tools.
> 
> https://github.com/spandruvada/linux-kernel/blob/intel-sst/tools/power/x86/intel-speed-select/hfi-events.c
> 
> I can replace with libthermal calls once ready. I will check the code
> below next week.

Great, thanks!

In attachment a test file as an example of the library usage.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
View attachment "test-thermal.c" of type "text/x-csrc" (6098 bytes)