[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yf2scqKFRFwWBIlC@robh.at.kernel.org>
Date: Fri, 4 Feb 2022 16:45:06 -0600
From: Rob Herring <robh@...nel.org>
To: Conor.Dooley@...rochip.com
Cc: linus.walleij@...aro.org, brgl@...ev.pl, jassisinghbrar@...il.com,
thierry.reding@...il.com, u.kleine-koenig@...gutronix.de,
lee.jones@...aro.org, a.zummo@...ertech.it,
alexandre.belloni@...tlin.com, paul.walmsley@...ive.com,
palmer@...belt.com, aou@...s.berkeley.edu, geert@...ux-m68k.org,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-pwm@...r.kernel.org, linux-rtc@...r.kernel.org,
linux-riscv@...ts.infradead.org, krzysztof.kozlowski@...onical.com,
bin.meng@...driver.com, heiko@...ech.de, Lewis.Hanly@...rochip.com,
Daire.McNamara@...rochip.com, Ivan.Griffin@...rochip.com,
atishp@...osinc.com
Subject: Re: [PATCH v5 03/12] dt-bindings: i2c: add bindings for microchip
mpfs i2c
On Mon, Jan 31, 2022 at 03:55:32PM +0000, Conor.Dooley@...rochip.com wrote:
> On 31/01/2022 15:39, Rob Herring wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Mon, Jan 31, 2022 at 5:45 AM <conor.dooley@...rochip.com> wrote:
> >>
> >> From: Conor Dooley <conor.dooley@...rochip.com>
> >>
> >> Add device tree bindings for the i2c controller on
> >> the Microchip PolarFire SoC.
> >>
> >> Reviewed-by: Rob Herring <robh@...nel.org>
> >>
> >
> > There should not be a blank line here.
> >
> > Also, tags should be in chronological order typically. If Daire sent
> > this patch out with my tag, then the order is correct. If I gave it on
> > a version you sent, then it goes between Daire's and your S-o-b which
> > is the case here.
> Oh, thanks. Probably been messing this up right/left/centre.
>
> On another note, I know I'm still missing a RB still on some of the
> bindings, but what is the acceptance path for this series?
> Any left over bindings not taken by subsystems via yourself and the dts
> changes via Palmer's tree?
They should go via subsystems. I can take if you want, but not with
missing dependencies. I need my tree working.
Rob
Powered by blists - more mailing lists