linux-kernel - Re: [PATCH V5 3/6] usb: common: eud: Add driver support for Embedded USB Debugger(EUD)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9c1bcb8-74d6-9049-f4ab-e3fdb8a0ae5e@quicinc.com>
Date:   Fri, 4 Feb 2022 12:33:30 +0530
From:   Souradeep Chowdhury <quic_schowdhu@...cinc.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <pure.logic@...us-software.ie>,
        <bjorn.andersson@...aro.org>, <robh@...nel.org>,
        <linux-kernel@...r.kernel.org>, <quic_tsoni@...cinc.com>,
        <quic_psodagud@...cinc.com>, <quic_satyap@...cinc.com>,
        <quic_pheragu@...cinc.com>, <quic_rjendra@...cinc.com>,
        <quic_sibis@...cinc.com>, <quic_saipraka@...cinc.com>
Subject: Re: [PATCH V5 3/6] usb: common: eud: Add driver support for Embedded
 USB Debugger(EUD)


On 2/3/2022 4:44 PM, Greg KH wrote:
> On Thu, Feb 03, 2022 at 04:04:32PM +0530, Souradeep Chowdhury wrote:
>> Add support for control peripheral of EUD (Embedded USB Debugger) to
>> listen to events such as USB attach/detach, pet EUD to indicate software
>> is functional.Reusing the platform device kobj, sysfs entry 'enable' is
>> created to enable or disable EUD.
>>
>> To enable the eud the following needs to be done
>> echo 1 > /sys/bus/platform/.../enable
>>
>> To disable eud, following is the command
>> echo 0 > /sys/bus/platform/.../enable
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> ---
>>   Documentation/ABI/testing/sysfs-driver-eud |   9 ++
>>   drivers/usb/common/Kconfig                 |  10 ++
>>   drivers/usb/common/Makefile                |   1 +
>>   drivers/usb/common/qcom_eud.c              | 251 +++++++++++++++++++++++++++++
> This really should be drivers/usb/misc/ right?  No other code uses
> anything from this driver which is what "common" is for.
Ack
>
> thanks,
>
> greg k-h