linux-kernel - Re: [PATCH v1 1/1] device property: Don't split fwnode_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yfzkm1CVNNRqHzd7@paasikivi.fi.intel.com>
Date:   Fri, 4 Feb 2022 10:32:27 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Daniel Scally <djrscally@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH v1 1/1] device property: Don't split fwnode_get_irq*()
 APIs in the code

Hi Andy,

On Thu, Feb 03, 2022 at 02:56:13PM +0200, Andy Shevchenko wrote:
> New fwnode_get_irq_byname() landed after an unrelated function
> by ordering. Move fwnode_iomap(), so fwnode_get_irq*() APIs will
> go together.
> 
> No functional change intended.

I have no problem with the patch as such, but I have four patches moving
the implementation of this and other similar functions to OF and ACPI
frameworks. I moved what was here to OF/ACPI FWs as part of the fwnode
graph API implementation but some firmware type checks have crept back in
since that.

I'd prefer to prepend this patch to the rest of the set I have and get it
all merged through linux-pm tree, on the dependent patch reaches it.

-- 
Kind regards,

Sakari Ailus