linux-kernel - Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220204085145.GX1951@kadam>
Date:   Fri, 4 Feb 2022 11:51:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Tong Zhang <ztong0001@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Paul Bolle <pebolle@...cali.nl>, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, insop.song@...nspeed.com,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote:
> gs_fpgaboot is currently useless since the board specific code is
> removed in 06a3fab941da. Loading the driver will always fail since
> xl_init_io() always returns -1. This driver is broken since 2014 and I
> doubt anyone is actually using it, we could either remove it or revert
> to the previous working version.
> 
> $ modprobe gs_fpga
> GPIO INIT FAIL!!
> 
> This patch reverts previously removed code and adds a Kconfig to make
> this board selectable for PPC_85xx processors.
> 
> Fixes: 06a3fab941da ("staging: gs_fpgaboot: remove checks for CONFIG_B4860G100")
> Signed-off-by: Tong Zhang <ztong0001@...il.com>

The Fixes tag is not really accurate.  The code has never worked.  It
should be:

Fixes: e7185c6958ee ("staging: fpgaboot: Xilinx FPGA firmware download driver")

I assume you don't really have this hardware and you're just modprobing
drivers to as part of testing?  If you have this hardware then we can
preserve it.  Otherwise we should just delete the whole driver.  It's
been 8 years and no one has noticed that it doesn't probe.

regards,
dan carpenter