linux-kernel - Re: [PATCH v8 0/2] Renesas 8T49N241 device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Feb 2022 11:00:23 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Michal Simek <michal.simek@...inx.com>,
        Alex Helms <alexander.helms.jy@...esas.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
CC:     <robh+dt@...nel.org>, <sboyd@...nel.org>,
        <mturquette@...libre.com>, <geert+renesas@...der.be>,
        <david.cater.jc@...esas.com>
Subject: Re: [PATCH v8 0/2] Renesas 8T49N241 device driver

Hi,

On 2/4/22 10:36, Michal Simek wrote:
> Hi,
> 
> 
> On 10/21/21 23:31, Alex Helms wrote:
>> Changes in v8:
>>   * Use __ffs instead of ffs
>>   * Change from 64 bit to 32 bit division
>>   * Minor math changes to avoid possible overflow
>> Changes in v7:
>>   * Rebase on v5.15-rc6
>>   * Rename renesas24x_* functions to r8t49n24x_*
>>   * Implement determine_rate instead of round_rate
>>   * Implement prepare/unprepare
>>   * Use devm_clk_get_optional and ensure clk0, clk1, and xtal are attempted 
>> before dev_err_probe
>>   * Use ffs() in __renesas_bits_to_shift
>>   * Remove regmap read/write retry
>>   * More consistent debug logging
>>   * Resolved many C related naming and initialization issues
>> Changes in v6:
>>   * Rebase on v5.15-rc1
>>   * Ensure Rob's Reviewed-by tag is included
>> Changes in v5:
>>   * Rebase on v5.14-rc2
>>   * Move driver files from clk/renesas to clk
>> Changes in v4:
>>   * Add vendor prefix to dt binding compatible property
>>   * Remove clock-names description in dt binding
>>   * Remove redundant 'input-' prefix on clock names
>>   * Clarify the settings property in dt binding, add data type
>>   * Fix define spacing
>> Changes in v3:
>>   * Clarify settings property in device tree bindings schema is optional
>> Changes in v2:
>>   * Correct missing semicolon in 8t49n24x-core.c
>>
>> Alex Helms (2):
>>    dt-bindings: Add binding for Renesas 8T49N241
>>    clk: Add ccf driver for Renesas 8T49N241
>>
>>   .../bindings/clock/renesas,8t49n241.yaml      | 190 +++++
>>   MAINTAINERS                                   |   7 +
>>   drivers/clk/8t49n24x-core.c                   | 752 ++++++++++++++++++
>>   drivers/clk/8t49n24x-core.h                   | 242 ++++++
>>   drivers/clk/8t49n24x.c                        | 565 +++++++++++++
>>   drivers/clk/Kconfig                           |  21 +
>>   drivers/clk/Makefile                          |   2 +
>>   7 files changed, 1779 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
>>   create mode 100644 drivers/clk/8t49n24x-core.c
>>   create mode 100644 drivers/clk/8t49n24x-core.h
>>   create mode 100644 drivers/clk/8t49n24x.c
>>
>>
>> base-commit: 519d81956ee277b4419c723adfb154603c2565ba
> 
> DT binding has been already reviewed and driver itself was sent long time ago.
> What's the problem now?
> 
> sboyd: Can you please review or pick it up?
> 
> Arnd: IIRC someone told me that if there is no activity it could go via your 
> tree too.

I saw that kernel bot reported 3 issues. I have fixed them and send v9 and 
hopefully this can go in.

Thanks,
Michal