linux-kernel - Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Feb 2022 15:34:15 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     "giometti@...eenne.com" <giometti@...eenne.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "rasm@...up.pt" <rasm@...up.pt>,
        "jamesnuss@...ometrics.ca" <jamesnuss@...ometrics.ca>
Subject: Re: [PATCH] pps: clients: gpio: Propagate return value from
 pps_gpio_probe

On Wed, Feb 02, 2022 at 05:04:13PM +0000, Robert Hancock wrote:
> On Sun, 2022-01-30 at 10:35 +0100, Rodolfo Giometti wrote:
> > On 29/01/22 23:02, Robert Hancock wrote:
> > > On Thu, 2022-01-13 at 09:17 +0100, Rodolfo Giometti wrote:
> > > > On 12/01/22 22:07, Andy Shevchenko wrote:
> > > > > On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote:
> > > > > > If the pps-gpio driver was probed prior to the GPIO device it uses,
> > > > > > the
> > > > > > devm_gpiod_get call returned an -EPROBE_DEFER error, but
> > > > > > pps_gpio_probe
> > > > > > replaced that error code with -EINVAL, causing the pps-gpio probe to
> > > > > > fail and not be retried later. Propagate the error return value so
> > > > > > that
> > > > > > deferred probe works properly.
> > > > > 
> > > > > FWIW,
> > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > 
> > > > Acked-by: Rodolfo Giometti <giometti@...eenne.com>
> > > 
> > > It's not entirely clear to me what tree PPS patches are supposed to go
> > > through.
> > > Seems like some recent ones have gone through char-misc? Not sure if
> > > someone
> > > has this in their queue?
> > 
> > LinuxPPS has no its own tree. All related patches usually are sent to me to
> > be
> > acked and to Greg Kroah-Hartman for inclusion.
> > 
> > Ciao,
> > 
> > Rodolfo
> > 
> 
> It looks like some MAINTAINERS links should maybe be updated for PPS - the
> referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to
> be dead. There is http://linuxpps.org/doku.php which points to a new mailing
> list location as well, but that seems to have very little activity.
> 
> Greg, can you pick this patch ( https://lkml.org/lkml/2022/1/12/879 ) up?

Please use lore.kernel.org, lkml.org does not work with our tools, nor
do we have any control over it.

thanks,

greg k-h