linux-kernel - Re: [PATCH v2] drivers/firmware: Add missing platform_device_put() in sysfb_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yf1JPCD1L4qt0T2c@kroah.com>
Date:   Fri, 4 Feb 2022 16:41:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     Miaoqian Lin <linmq006@...il.com>, bp@...e.de,
        daniel.vetter@...ll.ch, linux-kernel@...r.kernel.org,
        tzimmermann@...e.de
Subject: Re: [PATCH v2] drivers/firmware: Add missing platform_device_put()
 in sysfb_create_simplefb

On Sun, Jan 16, 2022 at 06:31:09PM +0100, Javier Martinez Canillas wrote:
> On 1/16/22 13:16, Miaoqian Lin wrote:
> > Add the missing platform_device_put() before return from
> > sysfb_create_simplefb() in the error handling case.
> > 
> > Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> > Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> > ---
> > Changes in v2:
> > - Use goto label to avoid duplicating the error code logic.
> > ---
> >  drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

Does not apply to my tree :(