linux-kernel - Re: [PATCH] ARM: dts: at91: sama7g5: Add crypto nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1933f3a-bd62-0cd3-4e09-ea9c20d356ac@microchip.com>
Date:   Fri, 4 Feb 2022 18:42:46 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Tudor Ambarus - M18064 <Tudor.Ambarus@...rochip.com>,
        "Claudiu Beznea - M18063" <Claudiu.Beznea@...rochip.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama7g5: Add crypto nodes

On 04/02/2022 at 18:36, Tudor Ambarus - M18064 wrote:
> On 2/4/22 15:37, Tudor Ambarus wrote:
>> Describe and enable the AES, SHA and TDES crypto IPs.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
>> ---
>>   arch/arm/boot/dts/sama7g5.dtsi | 35 ++++++++++++++++++++++++++++++++++
>>   1 file changed, 35 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
>> index 7972cb8c2562..1f2731a64139 100644
>> --- a/arch/arm/boot/dts/sama7g5.dtsi
>> +++ b/arch/arm/boot/dts/sama7g5.dtsi
>> @@ -393,6 +393,29 @@ pit64b1: timer@...04000 {
>>   			clock-names = "pclk", "gclk";
>>   		};
>>   
>> +		aes: aes@...10000 {
>> +			compatible = "atmel,at91sam9g46-aes";
>> +			reg = <0xe1810000 0x100>;
>> +			interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
>> +			dmas = <&dma0 AT91_XDMAC_DT_PERID(1)>,
>> +			       <&dma0 AT91_XDMAC_DT_PERID(2)>;
>> +			dma-names = "tx", "rx";
>> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 27>;
>> +			clock-names = "aes_clk";
>> +			status = "okay";
>> +		};
>> +
>> +		sha: sha@...14000 {
>> +			compatible = "atmel,at91sam9g46-sha";
>> +			reg = <0xe1814000 0x100>;
>> +			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
>> +			dmas = <&dma0 AT91_XDMAC_DT_PERID(48)>;
>> +			dma-names = "tx";
>> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 83>;
>> +			clock-names = "sha_clk";
>> +			status = "okay";
>> +		};
>> +
>>   		flx0: flexcom@...18000 {
>>   			compatible = "atmel,sama5d2-flexcom";
>>   			reg = <0xe1818000 0x200>;
>> @@ -475,6 +498,18 @@ trng: rng@...10000 {
>>   			status = "disabled";
>>   		};
>>   
>> +		tdes@...14000 {
> tdes: tdes@...14000
> 
> I should have added a label here. Nicolas, maybe you can add it when applying,
> if everything else looks ok to you.

Yep, if everything else is okay I can definitively add it when applying.

Regards,
   Nicolas

>> +			compatible = "atmel,at91sam9g46-tdes";
>> +			reg = <0xe2014000 0x100>;
>> +			interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> +			dmas = <&dma0 AT91_XDMAC_DT_PERID(54)>,
>> +			       <&dma0 AT91_XDMAC_DT_PERID(53)>;
>> +			dma-names = "tx", "rx";
>> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 96>;
>> +			clock-names = "tdes_clk";
>> +			status = "okay";
>> +		};
>> +
>>   		flx4: flexcom@...18000 {
>>   			compatible = "atmel,sama5d2-flexcom";
>>   			reg = <0xe2018000 0x200>;
> 


-- 
Nicolas Ferre