linux-kernel - Re: [PATCH 1/3] cpumask: Add a x86-specific cpumask_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yf1qmXRVbd5g/Vni@zn.tnic>
Date:   Fri, 4 Feb 2022 19:04:09 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Marco Elver <elver@...gle.com>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] cpumask: Add a x86-specific cpumask_clear_cpu()
 helper

On Fri, Feb 04, 2022 at 04:46:24PM +0000, Luck, Tony wrote:
> > Also, always inline two more cpumask generic helpers.
> >
> > allyesconfig:
> >
> >    text    data     bss     dec     hex filename
> > 190553143       159425889       32076404        382055436       16c5b40c vmlinux.before
> > 190551812       159424945       32076404        382053161       16c5ab29 vmlinux.after
> 
> That looks odd. You added "always" to some inline functions, which I'd
> have thought might cause *more* inlining, and thus an increase in text
> size. But it actually went *down* by 1331 bytes.

Or maybe the compiler did some optimizations after the inlining. Here
are the numbers on an allmodconfig - 1073 bytes less with this patch.

   text    data     bss     dec     hex filename
27409158        31062465        26710144        85181767        513c547 vmlinux.before
27408085        31062821        26710144        85181050        513c27a vmlinux.after

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette