[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <mhng-ffd770d4-8f8a-417a-a589-f14d09f55282@palmer-ri-x1c9>
Date: Fri, 04 Feb 2022 10:56:21 -0800 (PST)
From: Palmer Dabbelt <palmer@...belt.com>
To: zong.li@...ive.com
CC: mturquette@...libre.com, sboyd@...nel.org,
Paul Walmsley <paul.walmsley@...ive.com>, lee.jones@...aro.org,
robh+dt@...nel.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org, zong.li@...ive.com
Subject: Re: [PATCH 0/4] Refactor the PRCI driver to reduce the complexity
On Wed, 19 Jan 2022 01:28:37 PST (-0800), zong.li@...ive.com wrote:
> This patch set tries to improve the PRCI driver to reduce the
> complexity, we remove the SoCs C files by putting putting all stuff in
> each SoCs header file, and include these SoCs-specific header files in
> core of PRCI. It can also avoid the W=1 kernel build warnings about
> variable defined but not used [-Wunused-const-variable=], like 'commit
> 487dc7bb6a0c ("clk: sifive:fu540-prci: Declare static const variable
> 'prci_clk_fu540' where it's used")' does.
>
> This patch set also contains the dt-bindings and dts change, because
> we change the macro name for fu540 and fu740 by adding the prefix
> respectively.
>
> Thanks all for your review and suggestions.
>
> Zong Li (4):
> dt-bindings: change the macro name of prci in header files and example
> riscv: dts: Change the macro name of prci in each device node
> clk: sifive: Add SoCs prefix in each SoCs-dependent data
IIUC these there aren't bisectable: the bindings change will break
builds of the DTs and drivers. I'm not sure what's generally the way to
go with these, but I always try to avoid broken builds in the middle of
patch sets.
Aside from that this generally looks good to me, but the DT and clock
folks are probably a better bet for a proper review here. Happy to take
this through the RISC-V tree, but IMO it's a better candidate for the
clock tree so
Acked-by: Palmer Dabbelt <palmer@...osinc.com> # aside from breaking bisect
Thanks!
> clk: sifive: Move all stuff into SoCs header files from C files
>
> .../devicetree/bindings/gpio/sifive,gpio.yaml | 2 +-
> .../bindings/pci/sifive,fu740-pcie.yaml | 2 +-
> .../bindings/serial/sifive-serial.yaml | 2 +-
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 22 +--
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 26 ++--
> drivers/clk/sifive/Makefile | 2 +-
> drivers/clk/sifive/fu540-prci.c | 89 ------------
> drivers/clk/sifive/fu540-prci.h | 91 +++++++++++-
> drivers/clk/sifive/fu740-prci.c | 134 ------------------
> drivers/clk/sifive/fu740-prci.h | 130 ++++++++++++++++-
> drivers/clk/sifive/sifive-prci.c | 5 -
> include/dt-bindings/clock/sifive-fu540-prci.h | 8 +-
> include/dt-bindings/clock/sifive-fu740-prci.h | 18 +--
> 13 files changed, 254 insertions(+), 277 deletions(-)
> delete mode 100644 drivers/clk/sifive/fu540-prci.c
> delete mode 100644 drivers/clk/sifive/fu740-prci.c
Powered by blists - more mailing lists