linux-kernel - Re: [PATCH bpf-next v3 1/2] bpf: limit bpf_core_types_are

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJy_ksv9hYDhjGvxzMQipa7Fw4DGrAajhSLZKZcPNBf8g@mail.gmail.com>
Date:   Fri, 4 Feb 2022 11:32:28 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Matteo Croce <mcroce@...ux.microsoft.com>
Cc:     bpf <bpf@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 1/2] bpf: limit bpf_core_types_are_compat() recursion

On Thu, Feb 3, 2022 at 4:55 PM Matteo Croce <mcroce@...ux.microsoft.com> wrote:
> +
> +               for (i = 0; i < local_vlen; i++, local_p++, targ_p++) {
> +                       if (level <= 1)
> +                               return -EINVAL;

<= 1 is not correct, since it makes
MAX_TYPES_ARE_COMPAT_DEPTH 2
misleading.
With <= 1 the recursion depth is just 1.
So I've changed to to <=0 to make the actual depth of 2.