linux-kernel - Re: [PATCH v3] crypto: octeontx2: remove CONFIG_DM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yf394bPkveX8ONCk@gondor.apana.org.au>
Date:   Sat, 5 Feb 2022 15:32:33 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Shijith Thotton <sthotton@...vell.com>
Cc:     Arnaud Ebalard <arno@...isbad.org>,
        Boris Brezillon <bbrezillon@...nel.org>,
        linux-crypto@...r.kernel.org, jerinj@...vell.com,
        sgoutham@...vell.com, anoobj@...vell.com,
        Srujana Challa <schalla@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Ovidiu Panait <ovidiu.panait@...driver.com>,
        chiminghao <chi.minghao@....com.cn>,
        Suheil Chandran <schandran@...vell.com>,
        Lukasz Bartosik <lbartosik@...vell.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] crypto: octeontx2: remove CONFIG_DM_CRYPT check

On Fri, Jan 28, 2022 at 07:27:42PM +0530, Shijith Thotton wrote:
> No issues were found while using the driver with dm-crypt enabled. So
> CONFIG_DM_CRYPT check in the driver can be removed.
> 
> This also fixes the NULL pointer dereference in driver release if
> CONFIG_DM_CRYPT is enabled.
> 
> ...
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008
> ...
> Call trace:
>  crypto_unregister_alg+0x68/0xfc
>  crypto_unregister_skciphers+0x44/0x60
>  otx2_cpt_crypto_exit+0x100/0x1a0
>  otx2_cptvf_remove+0xf8/0x200
>  pci_device_remove+0x3c/0xd4
>  __device_release_driver+0x188/0x234
>  device_release_driver+0x2c/0x4c
> ...
> 
> Fixes: 6f03f0e8b6c8 ("crypto: octeontx2 - register with linux crypto framework")
> Signed-off-by: Shijith Thotton <sthotton@...vell.com>
> ---
>  .../crypto/marvell/octeontx2/otx2_cptvf_algs.c  | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt