linux-kernel - Re: [PATCH] crypto: sl3516: remove redundant initializations of pointers in_sg and out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yf3+VF9P6TW97qOO@gondor.apana.org.au>
Date:   Sat, 5 Feb 2022 15:34:28 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "David S . Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: sl3516: remove redundant initializations of
 pointers in_sg and out_sg

On Sun, Jan 30, 2022 at 11:05:15PM +0000, Colin Ian King wrote:
> Pointers in_sg and out_sg are being initialized with values that are
> never read, they are being re-assigned the same values later on. The
> initializations are redundant, remove them in preference to the later
> assignments that are closer to when the pointers are being used.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/crypto/gemini/sl3516-ce-cipher.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt