linux-kernel - Re: [PATCH] Revert "fat: add simple validation for directory inode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8735kxx290.fsf@mail.parknet.co.jp>
Date:   Sat, 05 Feb 2022 15:21:15 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Gwendal Grignou <gwendal@...omium.org>
Cc:     dlunev@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "fat: add simple validation for directory inode"

Gwendal Grignou <gwendal@...omium.org> writes:

> This reverts commit a3082d526f2d406d4b488e49a508a0062a23314f.
>
> The reverted commit adds check for FAT images. However, the tools used
> for creating images for the Lego Mindstrom EV3 are not adding '.' and
> '..' entry in the 'Projects' directory.
> Without this fix, the kernel can not fill the inode structure for
> 'Projects' directory.
>
> See https://github.com/microsoft/pxt-ev3/issues/980
> And https://github.com/microsoft/uf2-linux/issues/6

Looks like the bug of those tools. If you want to add the workaround for
those tools, it should not break sane format.

I.e. the workaround should at least set the directory link count to work
rmdir(2) without warnings, then should test other operations if works
well.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>