[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yf41lZtUntrb8V7Z@kroah.com>
Date: Sat, 5 Feb 2022 09:30:13 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Iouri Tarassov <iourit@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
wei.liu@...nel.org, linux-hyperv@...r.kernel.org,
linux-kernel@...r.kernel.org, spronovo@...rosoft.com
Subject: Re: [PATCH v2 19/24] drivers: hv: dxgkrnl: Simple IOCTLs
LX_DXESCAPE, LX_DXMARKDEVICEASERROR, LX_DXQUERYSTATISTICS,
LX_DXQUERYCLOCKCALIBRATION
On Fri, Feb 04, 2022 at 06:34:17PM -0800, Iouri Tarassov wrote:
The subject line does not make sense, it is not a sentence.
> These IOCTLs are logically simple:
What is "these"?
> - input data is read
> - a message is sent to the host
> - the result is returned to the caller
>
> - LX_DXESCAPE (D3DKMTEscape)
> This IOCTL is used to send/receive private data between user mode
> driver and kernel mode driver. This is an extension of the WDDM APIs.
>
> - LX_DXMARKDEVICEASERROR (D3DKMTMarkDeviceAsError)
> The IOCTL is used to bring the dxgdevice object to the error state.
> Subsequent calls to use the device object will fail.
>
> - LX_DXQUERYSTATISTICS (D3DKMTQuerystatistics)
> The IOCTL is used to query various statistics from the compute device
> on the host.
>
> - LX_DXQUERYCLOCKCALIBRATION
> The IOCTL queries clock from the compute device.
Why is this not broken up into one-patch-per-ioctl like I asked?
{sigh}
I'm not reviewing this anymore, please rework it.
thanks,
greg k-h
Powered by blists - more mailing lists