linux-kernel - Re: [PATCH v3 1/4] clk: actions: Terminate clk_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5567d063-39b3-adfb-6556-d9973fa2074b@amsat.org>
Date:   Sat, 5 Feb 2022 13:15:46 +0100
From:   Philippe Mathieu-Daudé <f4bug@...at.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-clk@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mips@...r.kernel.org,
        Manivannan Sadhasivam <mani@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Andreas Färber <afaerber@...e.de>,
        Saravanan Sekar <sravanhome@...il.com>,
        Parthiban Nallathambi <pn@...x.de>,
        linux-actions@...ts.infradead.org
Subject: Re: [PATCH v3 1/4] clk: actions: Terminate clk_div_table with
 sentinel element

On 5/2/22 01:52, Jonathan Neuschäfer wrote:
> In order that the end of a clk_div_table can be detected, it must be
> terminated with a sentinel element (.div = 0).
> 
> In owl-s900.s, the { 0, 8 } element was probably meant to be just that,
> so this patch changes { 0, 8 } to { 0, 0 }.
> 
> Fixes: d47317ca4ade1 ("clk: actions: Add S700 SoC clock support")
> Fixes: d85d20053e195 ("clk: actions: Add S900 SoC clock support")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>
> ---
> 
> v3:
> - Interpret { 0, 8 } as a typo of { 0, 0 }, the sentinel element
> - Add R-b tag
> 
> v2:
> - Add Fixes tags
> ---
>   drivers/clk/actions/owl-s700.c | 1 +
>   drivers/clk/actions/owl-s900.c | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/actions/owl-s700.c b/drivers/clk/actions/owl-s700.c
> index a2f34d13fb543..617174644f728 100644
> --- a/drivers/clk/actions/owl-s700.c
> +++ b/drivers/clk/actions/owl-s700.c
> @@ -162,6 +162,7 @@ static struct clk_div_table hdmia_div_table[] = {
> 
>   static struct clk_div_table rmii_div_table[] = {
>   	{0, 4},   {1, 10},
> +	{0, 0},

Again, clearer to use:

         { /* sentinel */ }

(without the trailing comma, to enforce this is the last entry).

>   };
> 
>   /* divider clocks */
> diff --git a/drivers/clk/actions/owl-s900.c b/drivers/clk/actions/owl-s900.c
> index 790890978424a..63c4097c07ac7 100644
> --- a/drivers/clk/actions/owl-s900.c
> +++ b/drivers/clk/actions/owl-s900.c
> @@ -140,7 +140,7 @@ static struct clk_div_table rmii_ref_div_table[] = {
> 
>   static struct clk_div_table usb3_mac_div_table[] = {
>   	{ 1, 2 }, { 2, 3 }, { 3, 4 },
> -	{ 0, 8 },
> +	{ 0, 0 },
>   };
> 
>   static struct clk_div_table i2s_div_table[] = {
> --
> 2.34.1
>