linux-kernel - Re: [PATCH v1 1/1] iio: accel: adxl355: Replace custom definitions with generic from units.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Feb 2022 17:41:08 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Puranjay Mohan <puranjay12@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>
Subject: Re: [PATCH v1 1/1] iio: accel: adxl355: Replace custom definitions
 with generic from units.h

On Wed,  2 Feb 2022 19:37:23 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> The units.h provides MEGA and TERA. Replace custom ones.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/accel/adxl355_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
> index 4f485909f459..7023de888835 100644
> --- a/drivers/iio/accel/adxl355_core.c
> +++ b/drivers/iio/accel/adxl355_core.c
> @@ -20,6 +20,8 @@
>  #include <linux/mod_devicetable.h>
>  #include <linux/of_irq.h>
>  #include <linux/regmap.h>
> +#include <linux/units.h>
> +
>  #include <asm/unaligned.h>
>  
>  #include "adxl355.h"
> @@ -60,9 +62,6 @@
>  #define ADXL355_PARTID_VAL		0xED
>  #define ADXL355_RESET_CODE		0x52
>  
> -#define MEGA 1000000UL
> -#define TERA 1000000000000ULL
> -
>  static const struct regmap_range adxl355_read_reg_range[] = {
>  	regmap_reg_range(ADXL355_DEVID_AD_REG, ADXL355_FIFO_DATA_REG),
>  	regmap_reg_range(ADXL355_OFFSET_X_H_REG, ADXL355_SELF_TEST_REG),