linux-kernel - Re: [PATCH] hwmon: (asus-ec-sensors) read sensors as signed ints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB95QARG9ZUNOcE=vcsZ7qV=eRXKxEfh+aqRBbWcWTreN7jDUg@mail.gmail.com>
Date:   Sat, 5 Feb 2022 19:10:20 +0100
From:   Eugene Shalygin <eugene.shalygin@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Oleksandr Natalenko <oleksandr@...alenko.name>,
        Denis Pauk <pauk.denis@...il.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwmon: (asus-ec-sensors) read sensors as signed ints

> Hmm, I hope we won't get a situation where an unsigned is reported
> and needed, but I guess we can deal with that if/when it happens.

There is still one byte left in the sensor address structure, which I
planned to put data format flags into, and the signees can be one of
those. I know that interpreting the reading for the VRM temperature
misses something, because while the reported value matches the one
reported by the ASUS software when the system thermal state is close
to a thermal equilibrium, right after booting its value (at least with
my board) is lower than the ambient temperature.

Eugene