linux-kernel - Re: [PATCH] btrfs: send: in case of IO error log inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOE4rSwu9Ond3qO2ADA=HPo5bRPq2BgBvJF6=J8efhzL73rrqg@mail.gmail.com>
Date:   Sat, 5 Feb 2022 03:35:44 +0200
From:   Dāvis Mosāns <davispuh@...il.com>
To:     David Sterba <dsterba@...e.cz>,
        Dāvis Mosāns <davispuh@...il.com>,
        BTRFS <linux-btrfs@...r.kernel.org>, Chris Mason <clm@...com>,
        Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] btrfs: send: in case of IO error log inode

piektd., 2022. g. 4. febr., plkst. 18:29 — lietotājs David Sterba
(<dsterba@...e.cz>) rakstīja:
>
> On Wed, Feb 02, 2022 at 10:14:37PM +0200, Dāvis Mosāns wrote:
> > Currently if we get IO error while doing send then we abort without
> > logging information about which file caused issue.
> > So log inode to help with debugging.
>
> The Signed-off-by tag is missing.
>

Yeah I forgot.

> > ---
> >  fs/btrfs/send.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> > index d8ccb62aa7d2..945d9c01d902 100644
> > --- a/fs/btrfs/send.c
> > +++ b/fs/btrfs/send.c
> > @@ -5000,6 +5000,7 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
> >                       if (!PageUptodate(page)) {
> >                               unlock_page(page);
> >                               put_page(page);
> > +                             btrfs_err(fs_info, "received IO error for inode=%llu", sctx->cur_ino);
>
> A message here makes sense. I'd make it more explicit that it's for send
> (the word "received" is kind of confusing), the inode number is not
> unique identifier so the root id should be also printed, it's available
> from the sctx->send_root and maybe also the file offset (taken from the
> associated page by page_offset()).

Thanks! Will submit v2